View Issue Details

IDProjectCategoryView StatusLast Update
0000791LDMud 3.5Efunspublic2018-01-30 03:59
ReporterLeonidas Assigned Tozesstra  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformWin32OSWindowsOS VersionWin7-64
Fixed in Version3.5.0 
Summary0000791: ldmud-3.5.0_svn2973: 32bit-restore_object() does not balk at reading 64bit-integers in a mapping
DescriptionModified value in savefile of player (XP stored as int value in a mapping assigned to string key). Upon login no error/warning occured - bits 33-64 seem to be simply ignored.
TagsNo tags attached.

Relationships

child of 0000555 closed Complete support for 64bit (LP64) architectures 

Activities

zesstra

2012-12-04 20:27

administrator   ~0002160

I have prepared a patch for issuing a warning in this case. However, I would like to have comments on it, because:
a) should it be a hard error or the warning?
b) I changed the number parsing to use strtoimax() - anybody thinks this is a problem?
c) I think, in case of int number a wrong adresse in <pt> was returned - the address of the delimeter, not the address of the char behind the delimeter. (line 8371)
d) a second patch changes restoring floats on foreign hosts to use strtod() instead of the deprecated atof(). Throws a warning upon overflows now as well.

The diff and the two commits are at:
https://github.com/zesstra/ldmud/compare/master...791-intoverflow

zesstra

2013-01-21 22:56

administrator   ~0002183

Fix committed in revision 890dfee0e56ef559c9af0ad11e7511313a0b166d to master branch (see changeset 888 for details). Thank you for reporting!

zesstra

2018-01-29 18:59

administrator   ~0002321

Fix committed in revision 890dfee0e56ef559c9af0ad11e7511313a0b166d to master branch (see changeset 1506 for details). Thank you for reporting!

zesstra

2018-01-29 21:57

administrator   ~0002372

Fix committed in revision 890dfee0e56ef559c9af0ad11e7511313a0b166d to master branch (see changeset 2836 for details). Thank you for reporting!

zesstra

2018-01-30 03:59

administrator   ~0002423

Fix committed in revision 890dfee0e56ef559c9af0ad11e7511313a0b166d to master branch (see changeset 3919 for details). Thank you for reporting!

Issue History

Date Modified Username Field Change
2011-10-31 18:54 Leonidas New Issue
2012-07-17 19:25 zesstra Relationship added child of 0000555
2012-12-04 20:27 zesstra Note Added: 0002160
2012-12-04 20:27 zesstra Assigned To => zesstra
2012-12-04 20:27 zesstra Status new => assigned
2013-01-21 22:56 zesstra Source_changeset_attached => ldmud.git master 890dfee0
2013-01-21 22:56 zesstra Source_changeset_attached => ldmud.git master 151f6bb9
2013-01-21 22:56 zesstra Note Added: 0002183
2013-01-21 22:56 zesstra Status assigned => resolved
2013-01-21 22:56 zesstra Resolution open => fixed
2017-10-04 18:55 zesstra Fixed in Version => 3.5.0
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master 151f6bb9
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master 890dfee0
2018-01-29 18:59 zesstra Note Added: 0002321
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master 151f6bb9
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master 890dfee0
2018-01-29 21:57 zesstra Note Added: 0002372
2018-01-30 03:59 zesstra Source_changeset_attached => ldmud.git master 151f6bb9
2018-01-30 03:59 zesstra Source_changeset_attached => ldmud.git master 890dfee0
2018-01-30 03:59 zesstra Note Added: 0002423