View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000472 | LDMud 3.3 | Implementation | public | 2006-06-05 12:29 | 2008-07-26 14:18 |
| Reporter | fufu | Assigned To | fufu | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000472: say(), tell_room(), printf() and tell_object() efuns truncate output on \0 | ||||
| Description | For example, printf("a\00morestuff") results in just a being sent. write() is fine -- the output is amorestuff. As far as I can see, the \0 is filtered because it's not in my telnet's character set. | ||||
| Additional Information | In fact, printf() goes through tell_object() for printing stuff; the attached patch fixes tell_object(), tell_room() and say(). | ||||
| Tags | No tags attached. | ||||
|
|
Mhmm, the patch seems to be OK for me. |
|
|
For me, too. |
|
2008-07-09 12:50
|
fmt_string.patch (558 bytes)
commit d6b3ee6cd9a47e755c028b3074262ab77fac5e3c
Author: Bertram Felgenhauer <int-e@gmx.de>
Date: Wed Jul 9 18:48:09 2008 +0200
second cut at #472
diff --git a/src/object.c b/src/object.c
index 9a355fe..26d8d06 100644
--- a/src/object.c
+++ b/src/object.c
@@ -1291,7 +1291,7 @@ tell_object (object_t *ob, string_t *str)
{
save_command_giver = command_giver;
command_giver = ob;
- add_message("%s", get_txt(str));
+ add_message(FMT_STRING, str);
command_giver = save_command_giver;
return;
}
|
|
|
This is trivial with the new patch for 0000471. |
|
|
fixed in commit 2396 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-06-05 12:29 | fufu | New Issue | |
| 2006-06-05 12:29 | fufu | File Added: fmt_string.diff | |
| 2008-07-02 04:34 | fufu | Status | new => assigned |
| 2008-07-02 04:34 | fufu | Assigned To | => fufu |
| 2008-07-08 18:13 | zesstra | Note Added: 0000691 | |
| 2008-07-09 03:45 | zesstra | Relationship added | related to 0000471 |
| 2008-07-09 10:28 | Gnomi | Note Added: 0000702 | |
| 2008-07-09 12:50 | fufu | File Added: fmt_string.patch | |
| 2008-07-09 12:51 | fufu | Note Added: 0000706 | |
| 2008-07-09 12:52 | fufu | File Deleted: fmt_string.diff | |
| 2008-07-26 14:18 | fufu | Status | assigned => resolved |
| 2008-07-26 14:18 | fufu | Resolution | open => fixed |
| 2008-07-26 14:18 | fufu | Note Added: 0000752 |
