View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000442 | LDMud 3.3 | Networking | public | 2006-01-09 13:12 | 2018-01-29 22:57 |
| Reporter | fippo | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.3.712 | ||||
| Fixed in Version | 3.3.716 | ||||
| Summary | 0000442: socket closes after reading MAX_TEXT bytes | ||||
| Description | When reading large chunks of data from a socket, the driver prematurely closes the socket. ip->text_end remains at MAX_TEXT, which triggers a zero-byte read in the next cycle, closing the socket. In the attached example 'reader.c', feed is called first with a newline \n only (most likely the result of a 'faking NL' ~ line 3230 of comm.c), then with the data, finally with an empty string. After that, the driver tries to read zero bytes, which closes the socket. Workaround: increase MAX_TEXT (hint: decrease MAX_TEXT for debugging :-) | ||||
| Tags | No tags attached. | ||||
|
2006-01-09 13:12
|
|
|
2006-01-09 13:26
|
|
|
|
test.py reproduces the bug (with MAX_TEXT set to 128). Only the string of ones is received on LPC level |
|
|
While the problem is indeed caused with the faking of a NL when reading a full buffers worth of data in charmode with combine-charset(!), I couldn't quite determine what exactly is going wrong. The cheap solution is simply to not read MAX_TEXT worth of data in charmode, avoiding the situation altogether. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-01-09 13:12 | fippo | New Issue | |
| 2006-01-09 13:12 | fippo | File Added: reader.c | |
| 2006-01-09 13:26 | fippo | File Added: test.py | |
| 2006-01-09 13:27 | fippo | Note Added: 0000473 | |
| 2007-10-07 18:42 |
|
Status | new => resolved |
| 2007-10-07 18:42 |
|
Fixed in Version | => 3.3.716 |
| 2007-10-07 18:42 |
|
Resolution | open => fixed |
| 2007-10-07 18:42 |
|
Assigned To | => lars |
| 2007-10-07 18:42 |
|
Note Added: 0000561 | |
| 2010-11-16 10:42 |
|
Source_changeset_attached | => ldmud.git master 3ba704b3 |
| 2018-01-29 19:59 |
|
Source_changeset_attached | => ldmud.git master 3ba704b3 |
| 2018-01-29 22:57 |
|
Source_changeset_attached | => ldmud.git master 3ba704b3 |
