View Issue Details

IDProjectCategoryView StatusLast Update
0000485LDMud 3.3Efunspublic2018-01-29 21:57
ReporterGnomi Assigned Tolars 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformi686OSDebian GNU/LinuxOS Version3.1
Fixed in Version3.3.717 
Summary0000485: Every sha1/md5 iteration should cost evals
DescriptionHi,

the evaluation cost for sha1() or md5() calls is constant, regardless of the given iteration count. So it is possible, to calculate the hash sum with __INT_MAX__ iterations which would probably halt a MUD for over an hour. Even eval costs of 1 per iteration is a bit cheap, because the hash calculation is very CPU intensive. (This could halt our MUD for up to half a second per thread). So, I would recommend 5 to 10 eval points per iteration.

Greetings,
Gnomi.
TagsNo tags attached.

Activities

lars

2007-11-11 18:08

reporter   ~0000579

I used 5 ticks per iteration for now.

Issue History

Date Modified Username Field Change
2006-09-11 05:03 Gnomi New Issue
2007-11-11 18:08 lars Status new => resolved
2007-11-11 18:08 lars Fixed in Version => 3.3.717
2007-11-11 18:08 lars Resolution open => fixed
2007-11-11 18:08 lars Assigned To => lars
2007-11-11 18:08 lars Note Added: 0000579
2009-04-14 12:14 zesstra Project LDMud => LDMud 3.3
2010-11-16 09:42 lars Source_changeset_attached => ldmud.git master eeaf3ff2
2018-01-29 18:59 lars Source_changeset_attached => ldmud.git master eeaf3ff2
2018-01-29 21:57 lars Source_changeset_attached => ldmud.git master eeaf3ff2