View Issue Details

IDProjectCategoryView StatusLast Update
0000486LDMud 3.3Efunspublic2018-01-29 22:57
ReporterGnomi Assigned ToGnomi  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformi686OSDebian GNU/LinuxOS Version3.1
Fixed in Version3.3.717 
Summary0000486: input_to with INPUT_PROMPT but an invalid prompt leaks the prompt and all additional parameters
DescriptionHi,

efun::input_to("bla",4,({1}),({2}))

yields

2006.09.11 16:36:32 --- Garbage Collection ---
freeing small block 0x0907173c (user 0x09071744) interpret.c::allocate_uninit_array 14709
  By object: w/gnomi/LPC_zst
  By program: w/gnomi/LPC_zst.c line:15
09071758: 01 00 00 00 01 00 00 00 07 00 00 00 44 d1 0f 09 ............D...
09071768: 02 00 00 00 02 00 00 00 4e 05 00 38 ab d8 58 ab ........N..8..X.
09071778: ac c3 06 09 29 00 00 ....)..

freeing small block 0x090717a4 (user 0x090717ac) interpret.c::allocate_uninit_array 14709
  By object: w/gnomi/LPC_zst
  By program: w/gnomi/LPC_zst.c line:15
090717c0: 01 00 00 00 01 00 00 00 05 00 00 00 44 d1 0f 09 ............D...
090717d0: 02 00 00 00 01 00 00 00 68 05 00 38 ab d8 58 ab ........h..8..X.
090717e0: ac c3 06 09 29 00 00 ....)..

2 small blocks freed

Greetings,
Gnomi.
TagsNo tags attached.

Activities

2006-09-12 04:15

 

inputtoleak.diff (637 bytes)   
Index: trunk/src/comm.c
===================================================================
--- trunk/src/comm.c	(Revision 2312)
+++ trunk/src/comm.c	(Arbeitskopie)
@@ -7622,7 +7622,7 @@
 
         if (arg[2].type != T_STRING && arg[2].type != T_CLOSURE)
         {
-            vefun_bad_arg(3, arg-1);
+            vefun_bad_arg(3, sp);
             /* NOTREACHED */
         }
     }
@@ -7691,7 +7691,7 @@
     if (error_index >= 0)
     {
         free_input_to(it);
-        vefun_bad_arg(error_index, arg-1);
+        vefun_bad_arg(error_index + num_arg - extra + 1, arg-1);
         /* NOTREACHED */
         return arg-1;
     }
inputtoleak.diff (637 bytes)   

Gnomi

2008-07-01 09:46

manager   ~0000646

Fixed in 3.3.717 (r2370).

Issue History

Date Modified Username Field Change
2006-09-11 09:40 Gnomi New Issue
2006-09-12 04:15 Gnomi File Added: inputtoleak.diff
2008-06-30 05:08 Gnomi Status new => assigned
2008-06-30 05:08 Gnomi Assigned To => Gnomi
2008-07-01 09:46 Gnomi Status assigned => resolved
2008-07-01 09:46 Gnomi Fixed in Version => 3.3.717
2008-07-01 09:46 Gnomi Resolution open => fixed
2008-07-01 09:46 Gnomi Note Added: 0000646
2009-04-14 14:14 zesstra Project LDMud => LDMud 3.3
2010-11-16 10:42 zesstra Source_changeset_attached => ldmud.git master c48a5f70
2010-11-16 10:42 Gnomi Source_changeset_attached => ldmud.git master 8ffd7cb6
2018-01-29 19:59 zesstra Source_changeset_attached => ldmud.git master c48a5f70
2018-01-29 19:59 Gnomi Source_changeset_attached => ldmud.git master 8ffd7cb6
2018-01-29 22:57 zesstra Source_changeset_attached => ldmud.git master c48a5f70
2018-01-29 22:57 Gnomi Source_changeset_attached => ldmud.git master 8ffd7cb6