View Issue Details

IDProjectCategoryView StatusLast Update
0000825LDMud 3.5Implementationpublic2018-01-30 03:59
Reporterzesstra Assigned Tozesstra  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Platformx86_64OSMacOS XOS Version10.6.x
Target Version3.5.0Fixed in Version3.5.0 
Summary0000825: sprintf.c contains several theoretical buffer overflows with checks and fatal() calls
Descriptionsprintf.c has 3 occurances of this construct:

(writing with strcat/sprintf in temp)
tmpl = strlen(temp);
if ((size_t)tmpl >= sizeof(temp))
     fatal("Local buffer overflow in sprintf() for int.\n");

These calls to fatal() are completely unnecessary, because we could use snprintf() or strncat() and prevent the buffer overflow in the first place.
Tagssprintf

Activities

zesstra

2013-08-30 23:08

administrator   ~0002208

Fixed in master now.

zesstra

2018-01-29 18:59

administrator   ~0002317

Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 1485 for details). Thank you for reporting!

zesstra

2018-01-29 21:57

administrator   ~0002368

Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 2814 for details). Thank you for reporting!

zesstra

2018-01-30 03:59

administrator   ~0002419

Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 3898 for details). Thank you for reporting!

Issue History

Date Modified Username Field Change
2013-08-18 18:52 zesstra New Issue
2013-08-18 23:02 zesstra Tag Attached: sprintf
2013-08-18 23:02 zesstra Assigned To => zesstra
2013-08-18 23:02 zesstra Status new => assigned
2013-08-30 23:08 zesstra Note Added: 0002208
2013-08-30 23:08 zesstra Status assigned => resolved
2013-08-30 23:08 zesstra Fixed in Version => 3.5.0
2013-08-30 23:08 zesstra Resolution open => fixed
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master ebf1fc94
2018-01-29 18:59 zesstra Note Added: 0002317
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master ebf1fc94
2018-01-29 21:57 zesstra Note Added: 0002368
2018-01-30 03:59 zesstra Source_changeset_attached => ldmud.git master ebf1fc94
2018-01-30 03:59 zesstra Note Added: 0002419