View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000836 | LDMud 3.5 | Runtime | public | 2014-09-07 22:35 | 2018-01-30 04:59 |
| Reporter | zesstra | Assigned To | zesstra | ||
| Priority | high | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x86_64 | OS | MacOS X | OS Version | 10.9.x |
| Target Version | 3.5.0 | Fixed in Version | 3.5.0 | ||
| Summary | 0000836: Crash when determining a result type of a struct member lookup operation when struct is unknown. | ||||
| Description | During get_struct_member_result_type() struct_find_member() and struct_t_size() may be called with the struct being NULL. This is not handled by the two called functions - however, I am not sure if they should. (Would be more robust, if they do.) get_struct_member_result_type() should probably detect that and not call them in the first hand. Preceding the crash is a compile error due to an unknown struct: secure/errord.c line 1: Unknown struct 'fullissue_s' before ' issue)'. The crashing code is basically (with no struct fullissue_s defined anywhere): int db_insert_issue(struct fullissue_s issue) { return issue->id; } This is especially unfortunate, because a typo in the struct name will lead to the crash if a struct member is referenced. | ||||
| Tags | structs | ||||
|
|
I have a fix for it in get_struct_member_result_type() and get_lpctype_name_buf(), but maybe there are better ways of handling it. Details tomorrow. |
|
|
Fix committed in revision 604e228d2f2a6afcebb260e75b1c4ef626bbfa61 to master branch (see changeset 966 for details). Thank you for reporting! |
|
|
Fix committed in revision 604e228d2f2a6afcebb260e75b1c4ef626bbfa61 to master branch (see changeset 1427 for details). Thank you for reporting! |
|
|
Fix committed in revision 604e228d2f2a6afcebb260e75b1c4ef626bbfa61 to master branch (see changeset 2755 for details). Thank you for reporting! |
|
|
Fix committed in revision 604e228d2f2a6afcebb260e75b1c4ef626bbfa61 to master branch (see changeset 3840 for details). Thank you for reporting! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-09-07 22:35 | zesstra | New Issue | |
| 2014-09-07 22:47 | zesstra | Tag Attached: structs | |
| 2014-09-08 00:17 | zesstra | Status | new => confirmed |
| 2014-09-08 00:31 | zesstra | Note Added: 0002239 | |
| 2014-09-08 19:53 | zesstra | Assigned To | => zesstra |
| 2014-09-08 19:53 | zesstra | Status | confirmed => assigned |
| 2014-09-08 20:05 | zesstra | Source_changeset_attached | => ldmud.git master 604e228d |
| 2014-09-08 20:05 | zesstra | Note Added: 0002240 | |
| 2014-09-08 20:05 | zesstra | Status | assigned => resolved |
| 2014-09-08 20:05 | zesstra | Resolution | open => fixed |
| 2015-01-23 21:37 | zesstra | Fixed in Version | => 3.5.0 |
| 2018-01-29 19:59 | zesstra | Source_changeset_attached | => ldmud.git master 604e228d |
| 2018-01-29 19:59 | zesstra | Note Added: 0002313 | |
| 2018-01-29 22:57 | zesstra | Source_changeset_attached | => ldmud.git master 604e228d |
| 2018-01-29 22:57 | zesstra | Note Added: 0002364 | |
| 2018-01-30 04:59 | zesstra | Source_changeset_attached | => ldmud.git master 604e228d |
| 2018-01-30 04:59 | zesstra | Note Added: 0002415 |
