View Issue Details

IDProjectCategoryView StatusLast Update
0000729LDMud 3.3Compilation, Installationpublic2018-01-30 03:59
Reportergraveluth Assigned Tozesstra  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.3.719 
Target Version3.3.720Fixed in Version3.3.720 
Summary0000729: Replacement of macro parameters doesn't strip trailing whitespaces
DescriptionThe macro:

#define quote(X) "X"

with the usage (please note the whitespace before the closing parenthesis):

quote( foo )

leads to:

"foo "
Additional InformationPlease, also note that this bug is obsolete if something like the C preprocessor # is introduced (see issue 0000174)
TagsNo tags attached.

Relationships

related to 0000174 new LDMud Preprocessor is not ISO-C compatible. 

Activities

zesstra

2010-11-20 18:21

administrator   ~0001927

Mhmmm. As far as I can see, it should be sufficient to skip the whitespace in the default case of the big switch in _expand_define(). That will also skip any other whitespace in the argument list, not only the trailing.

zesstra

2011-01-06 22:59

administrator   ~0001941

Fix committed in revision a5dacaba7c482f961a32336441d05ce302cfa630 to master-3.3 branch (see changeset 735 for details). Thank you for reporting!

zesstra

2011-01-07 21:12

administrator   ~0001942

Ok, never be too unimaginative. Of course it is not a good idea to skip all whitespaces in the arguments. Thanks Bardioc.
I was completely fixated on the fact that we also have to skip whitespace before and after each individual argument (not only before and after the last argument) and completely missed the whitespace within an argument which has to survive. *sigh*

zesstra

2011-01-07 23:08

administrator   ~0001943

I revised my changes from yesterday to skip only the leading and trailing whitespace of each argument and committed it to trunk/master.
I hope, there aren't any wizards who depend on the old behaviour of preserving most of the whitespace...

Could you please test and report back if this does not introduce new/other problems?

graveluth

2011-01-08 13:43

reporter   ~0001944

From my point of view this works fine - I couldn't find any new bugs so far.

Thanks for fixing.

zesstra

2011-01-08 18:33

administrator   ~0001945

Great. If there are any, you can re-open the issue.

zesstra

2011-01-08 23:17

administrator   ~0001946

Fix committed in revision a13299814b82b459bb2fe7a03d9850b57d401938 to master-3.3 branch (see changeset 737 for details). Thank you for reporting!

zesstra

2018-01-29 18:59

administrator   ~0002336

Fix committed in revision a5dacaba7c482f961a32336441d05ce302cfa630 to master-3.3 branch (see changeset 2250 for details). Thank you for reporting!

zesstra

2018-01-29 21:57

administrator   ~0002387

Fix committed in revision a5dacaba7c482f961a32336441d05ce302cfa630 to master-3.3 branch (see changeset 3595 for details). Thank you for reporting!

zesstra

2018-01-30 03:59

administrator   ~0002438

Fix committed in revision fb9e37b807285445be0d7f9c7250536334afc707 to master branch (see changeset 4027 for details). Thank you for reporting!

Issue History

Date Modified Username Field Change
2010-02-23 07:55 graveluth New Issue
2010-03-14 17:51 zesstra Relationship added related to 0000174
2010-11-20 18:21 zesstra Note Added: 0001927
2010-11-20 18:21 zesstra Status new => confirmed
2010-11-20 18:45 zesstra Project LDMud 3.5 => LDMud 3.3
2010-11-20 18:46 zesstra Category LPC Compiler/Preprocessor => Compilation, Installation
2010-11-20 18:46 zesstra Product Version => 3.3.719
2010-11-20 18:46 zesstra Target Version => 3.3.720
2011-01-06 16:02 zesstra Assigned To => zesstra
2011-01-06 16:02 zesstra Status confirmed => assigned
2011-01-06 22:59 zesstra Source_changeset_attached => ldmud.git master fb9e37b8
2011-01-06 22:59 zesstra Source_changeset_attached => ldmud.git master-3.3 a5dacaba
2011-01-06 22:59 zesstra Note Added: 0001941
2011-01-06 22:59 zesstra Status assigned => resolved
2011-01-06 22:59 zesstra Resolution open => fixed
2011-01-06 23:05 zesstra Fixed in Version => 3.3.720
2011-01-07 21:12 zesstra Note Added: 0001942
2011-01-07 21:12 zesstra Status resolved => assigned
2011-01-07 21:12 zesstra Resolution fixed => open
2011-01-07 23:05 zesstra Source_changeset_attached => ldmud.git master 0f804a2c
2011-01-07 23:05 zesstra Resolution open => fixed
2011-01-07 23:08 zesstra Note Added: 0001943
2011-01-07 23:08 zesstra Status assigned => feedback
2011-01-07 23:08 zesstra Resolution fixed => reopened
2011-01-08 13:43 graveluth Note Added: 0001944
2011-01-08 13:43 graveluth Status feedback => assigned
2011-01-08 18:33 zesstra Note Added: 0001945
2011-01-08 18:33 zesstra Status assigned => resolved
2011-01-08 18:33 zesstra Resolution reopened => fixed
2011-01-08 23:17 zesstra Source_changeset_attached => ldmud.git master-3.3 a1329981
2011-01-08 23:17 zesstra Note Added: 0001946
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master 0f804a2c
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master fb9e37b8
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master-3.3 a1329981
2018-01-29 18:59 zesstra Source_changeset_attached => ldmud.git master-3.3 a5dacaba
2018-01-29 18:59 zesstra Note Added: 0002336
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master 0f804a2c
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master fb9e37b8
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master-3.3 a1329981
2018-01-29 21:57 zesstra Source_changeset_attached => ldmud.git master-3.3 a5dacaba
2018-01-29 21:57 zesstra Note Added: 0002387
2018-01-30 03:59 zesstra Source_changeset_attached => ldmud.git master 0f804a2c
2018-01-30 03:59 zesstra Source_changeset_attached => ldmud.git master fb9e37b8
2018-01-30 03:59 zesstra Note Added: 0002438